You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the new or updated feature that you are suggesting?
Opening this issue as requested by Kent in #1015 to discuss how to proceed
Run npm run build automatically when running npm run deploy like
"deploy": "npm run build && fly deploy --remote-only"
or add it to the templates readme to the ## Deployment desction
Why should this feature be included?
So, to me it was quite confusing, that running npm run deploy wouldn't update my website 😳 I know it's kinda my fault not properly checking what the npm scripts are doing, but there's also no mention of ever running npm run build in the Readme.
Therefore I propose either adding it to the readme or running it automatically before deploy.
Personally I prefer the latter as I don't have much reason to deploy without building, but there might be other preferences I guess.
As for what other templates are doing, the Workers one builds already before deploying and others don't require builds or deploys, as far as I can tell.
This discussion was converted from issue #1057 on April 19, 2022 22:28.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
What is the new or updated feature that you are suggesting?
Opening this issue as requested by Kent in #1015 to discuss how to proceed
Run
npm run build
automatically when runningnpm run deploy
likeor add it to the templates readme to the
## Deployment
desctionWhy should this feature be included?
So, to me it was quite confusing, that running
npm run deploy
wouldn't update my website 😳 I know it's kinda my fault not properly checking what the npm scripts are doing, but there's also no mention of ever runningnpm run build
in the Readme.Therefore I propose either adding it to the readme or running it automatically before deploy.
Personally I prefer the latter as I don't have much reason to deploy without building, but there might be other preferences I guess.
As for what other templates are doing, the Workers one builds already before deploying and others don't require builds or deploys, as far as I can tell.
Beta Was this translation helpful? Give feedback.
All reactions