fix(dev): keep dev server running when build fails (#5795)

remix-run · Mar 15, 2023 · 6a738d7 · 6a738d7
1 parent 23be6d0
commit 6a738d7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/dev-server-resilient-to-build-failures.md b/.changeset/dev-server-resilient-to-build-failures.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+dev server is resilient to build failures
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -22,4 +22,4 @@ jobs:
     if: github.repository == 'remix-run/remix'
     uses: ./.github/workflows/reusable-test.yml
     with:
-      node_version: '["latest"]'
+      node_version: '["19.7"]'
diff --git a/packages/remix-dev/compiler/remixCompiler.ts b/packages/remix-dev/compiler/remixCompiler.ts
@@ -43,11 +43,17 @@ export const compile = async (
     let assetsManifestChannel = createChannel<AssetsManifest>();
     let browserPromise = compiler.browser.compile(assetsManifestChannel);
     let serverPromise = compiler.server.compile(assetsManifestChannel);
+
+    // await browser/server _before_ assets manifest channel
+    // to fix https://github.com/remix-run/remix/issues/5631
+    // this is temporary and is actively being refactored
+    let browser = await browserPromise;
+    let server = await serverPromise;
     return {
       assetsManifest: await assetsManifestChannel.read(),
       metafile: {
-        browser: await browserPromise,
-        server: await serverPromise,
+        browser,
+        server,
       },
     };
   } catch (error: unknown) {