fix: webpack + React 17 won't build because of named imports of React 18 APIs #8938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8931 (Reopen since
/remixing
is deleted)In current build, rollup outputs these named exports:
useSyncExternalStore
,startTransition
from React. If the user's React version doesn't export them, Webpack won't build:This fix prevents rollup from outputting these named imports.
node_modules/react-router/index.js
:https://rollupjs.org/guide/en/#outputinterop
https://github.dev/webpack/webpack/blob/f9e6b682aba059d13aa3e170ac42b7a797a0ef3f/lib/dependencies/HarmonyImportDependency.js#L141