Warn of possible tooling loss on upgrade #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this! Made a couple of tweaks. |
jeresig
pushed a commit
to Khan/react-router
that referenced
this pull request
Aug 29, 2018
* Warn of possible tooling loss on upgrade * Small tweaks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya, thanks for all the fab work on these packages. So it wasn't until I was pretty far through the upgrade to react-router v4 that I found these issues with react-router-redux and React DevTools. Obviously it will take time for the tooling etc to catch up with new releases of popular packages, but would it be possible to publicise this issue a little more?