NavLink should render child components wrapped by withRouter #5141

[penx]

• Created failing test for NavLink - as per withRouter wrapped component only renders when NavLink is active #5141 and https://codepen.io/penx/pen/jmeEXz
• Fixed issue withRouter wrapped component only renders when NavLink is active #5141 - NavLink should render child components that are wrapped by withRouter

[pshrmn]

This falls under the same umbrella as #4704. The issue is a bit broader than just <NavLink>s because it applies to any withRouter wrapped component whose parent match is null (which can only happen inside of a parent <Route children>) .

[penx]

@ryanflorence @timdorr any chance of some feedback on this, or some progress on #4704? I've created a simple failing test in this PR which should illustrate the issue

[penx]

@ryanflorence @timdorr @pshrmn any chance on an update on this or #4704?

Is there any point in me fixing the conflicts here or is this fix not wanted?

I would hope that the unit test I have included, along with the codepen, illustrate what the issue is, but if you want more information please ask.

[pravdomil]

#5963

[timdorr]

Superceded by #5964

[penx]

@timdorr unit tests in this branch are still relevant, useful and not covered by #5964, please reopen for this for tests and I'll rebase from master

[timdorr]

I agree. Can you do a new PR? It'll be cleaner that way. Thanks!

[penx]

sure