Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): Use module-sync server condition when enabled #12729

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

markdalgleish
Copy link
Member

Fixes #12475.

In the linked issue, the module-sync condition is used by Node but not by Vite. To fix this, we detect whether the module-sync condition is being used in Node, and if so we add it to the list of Vite's server conditions.

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: f99c0af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish marked this pull request as ready for review January 13, 2025 22:58
@markdalgleish markdalgleish merged commit 6f2168e into dev Jan 13, 2025
8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/module-sync-condition branch January 13, 2025 23:45
@brophdawg11
Copy link
Contributor

it should available be in the nightly tag on npm

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"useSubmit must be used within a data router" for 3rd party libraries on node 22.12.0
3 participants