fix(dev): resolve optimizeDeps entries properly on Windows

[wKovacs64]

TL;DR - unstable_optimizeDeps doesn't work well on Windows due to path resolution issues. This fixes it. All credit goes to @sebastien-comeau for remix-run/remix#10258 (which still needs merged for the Windows folks still on Remix v2, btw).

[changeset-bot]

🦋 Changeset detected

Latest commit: a3ea46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@react-router/dev	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch
react-router	Patch
react-router-dom	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @wKovacs64,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[sebastien-comeau]

@wKovacs64 Merging is blocked

Merge is not an allowed merge method in this repository.

🤷

[wKovacs64]

Merge is not an allowed merge method in this repository.

Ah that's okay, it just says that because we don't have merge permissions. Looks like Pedro might be reviewing it, so 🤞

[pcattori]

Thanks for the fix @wKovacs64 ! Looks like we don't use unplugin's pathe replacement for node:path in our Vite plugin code yet which let this bug sneak through. Merging as-is, but just leaving a reminder to myself here that we should probably migrate all path API calls to pathe to get standardized, cross-platform paths everywhere.

[sebastien-comeau]

Thanks for the fix @wKovacs64 ! 🎉

[github-actions]

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.1.4-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!