temporarily only use one build in export map #12437
Conversation
with the export map before this commit, there’s a react router context mismatch in react-router-dev because the node process from `react-router dev` isn’t started with `—conditions development`, so it required the production build of `react-router` (because it’s used internally in `react-router-dev`. Then for the server render, “react-router” is already in the cache so if any node_modules have a peer dep on it, it gets the production build too. After that, app code runs and asks for “react-router” but this import is processed through vite with the “development” condition, so the app gets a different version of react router Now if a node_module want’s to useLocation inside of the app, it’s got a different copy of that hook and no router context This is a temporary patch until we can work out how to get `react-router dev` to get the development build in node without requiring apps to set the conditions
🦋 Changeset detectedLatest commit: 77f6f08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
with the export map before this commit, there’s a react router context mismatch in react-router-dev because the node process from
react-router devisn’t started with—conditions development, so it required the production build ofreact-router(because it’s used internally inreact-router-dev.Then for the server render, “react-router” is already in the cache so if any node_modules have a peer dep on it, it gets the production build too.
After that, app code runs and asks for “react-router” but this import is processed through vite with the “development” condition, so the app gets a different version of react router
Now if a node_module want’s to useLocation inside of the app, it’s got a different copy of that hook and no router context
This is a temporary patch until we can work out how to get
react-router devto get the development build in node without requiring apps to set the conditions