Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs-routes): throw error if routes directory is missing #12407

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

GuptaSiddhant
Copy link
Contributor

The flatRoutes function is supposed to throw error if the routesDir does not exist. But due to a type, it was checking for rootRoute again and throwing error regarding missing routesDir.

Fixed the typo and couple of tests to check for correct error to be thrown in both scenarios.

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 7e52bc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/fs-routes Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
@react-router/express Patch
@react-router/node Patch
@react-router/remix-routes-option-adapter Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the title fix: throw error if routesDir is missing in flatRoutes-fs fix(fs-routes): throw error if routes directory is missing Dec 3, 2024
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit d816819 into remix-run:dev Dec 3, 2024
5 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants