Remove duplicate RouterProvider implementations #11679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c6c99e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Jun 18, 2024
Comment on lines
+2
to
9
|
|
||
| // TODO: This static import doesn't allow us to work quite right in a pure-react | ||
| // app that doesn't even have react-dom as a dependency. Let's look into using | ||
| // an export map for `react-router/dom that would provide the `flushSync` method | ||
| // to the memory `<RouterProvider>` via a prop. And then | ||
| // `import { RouterProvider } from 'react-router/memory'` // memory use case | ||
| // `import { RouterProvider } from 'react-router/dom'` // DOM use case | ||
| import * as ReactDOM from "react-dom"; |
There was a problem hiding this comment.
We need to figure out what to do here - putting this on hold until we can discuss the export map setup next week with @mjackson and @markdalgleish
There was a problem hiding this comment.
merge this PR and make an issue for this?
ryanflorence
approved these changes
Jun 19, 2024
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have 2 of these since we kept DOM-specifics in
react-router-dom(document.startViewTransition,ReactDOM.flushSync) but now we just need the one and it can be defensive against the lack ofwindow/document