Skip vite-route-added-test in Safari
#11511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ohhh wait is this failing for you on v7 as well? This is the last thing locking #11505 and I assumed it had to do with the work in there since I don't think I'd seen it fail on any prior PRs of mine to v7. |
|
yup - just pulled latest v7 and did a clean build and it failed 10/10 times for me - glad to know I'm not crazy |
brophdawg11
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is consistently failing in Safari due to its aggressive caching causing it to hold onto an outdated browser manifest. This test was already flaky and for some reason seems to have gotten worse. I tried rolling back to a previously working state and I'm still seeing the same issue. Until we figure out how to fix this, I'm skipping this test in Safari so that it doesn't hold up CI.