Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Jest package setups #11391

Merged
merged 10 commits into from
Apr 1, 2024
Merged

Configure Jest package setups #11391

merged 10 commits into from
Apr 1, 2024

Conversation

brophdawg11
Copy link
Contributor

No description provided.

Comment on lines -26 to -30
watchPlugins: [
require.resolve("jest-watch-select-projects"),
require.resolve("jest-watch-typeahead/filename"),
require.resolve("jest-watch-typeahead/testname"),
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what these were doing but took them out to get rid of these warnings on running jest

Screenshot 2024-04-01 at 2 56 52 PM

Feels smarter to decouple from jest-specific stuff too in anticipation of potentially moving to vitest or node's built-in test runner in the future

@@ -0,0 +1,7 @@
node_modules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brought over the node/deno/cloudflare fixtures for the remix-dev tests, but if adapters live elsewhere dunno if these all make sense in here long term (at least deno + cloudflare)?

Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 7209066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router-dom-v5-compat Major
react-router-native Major
react-router-dom Major
react-router Major
@remix-run/router Major
@remix-run/dev Patch
@remix-run/server-runtime Patch
@remix-run/node Patch
@remix-run/testing Patch
@remix-run/express Patch
@remix-run/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 91a0850 into v7 Apr 1, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/jest branch April 1, 2024 20:25
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant