Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basename duplication in RouterProvider descendant routes #10492

Merged
merged 1 commit into from
May 16, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented May 15, 2023

  • In BrowserRouter, useNavigateUnstable will handle resolving the relative path and prepending the basename
  • In RouterProvider, the router.navigate will handle resolving relative paths and prepending the basename

However, If you use RouterProvider and include some descendant <Routes> inside the tree, then that needs to use useNavigateUnstable to resolve relative paths but it should not also prepend the basename since navigation will still go through router.navigate

Closes #10467

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: bc0071d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue May 15, 2023 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit e665a46 into dev May 16, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/basename-nested-routess branch May 16, 2023 13:18
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Basename is duplicated in nested routes
4 participants