Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill router reducer with initial data #5061

Closed
DimitryDushkin opened this issue May 2, 2017 · 5 comments
Closed

Fill router reducer with initial data #5061

DimitryDushkin opened this issue May 2, 2017 · 5 comments

Comments

@DimitryDushkin
Copy link

DimitryDushkin commented May 2, 2017

  1. It will be nice to fill up router state with corresponding initial data (default value).
  2. (again) Initial LOCATION_CHANGE action is still misleading and should be removed:
    1. Location is actually not changing on page refresh for example
    2. Also if you opening some link from address bar location is not changing from about: blank by default (it should be configured), so location is not actually changing.
    3. History API does not fire such event on loading
@timdorr
Copy link
Member

timdorr commented May 2, 2017

Please don't open duplicate issues. #5038

@timdorr timdorr closed this as completed May 2, 2017
@DimitryDushkin
Copy link
Author

@timdorr I've added one more proposal (didn't present in duplicate) and you didn't answered to my arguments in prior issue, so I've added them to this related issue.

@DimitryDushkin
Copy link
Author

Anyway what's the point in closing issues without discussion and agreement?

@timdorr
Copy link
Member

timdorr commented May 2, 2017

Because it's an alpha. Things will change and we haven't even figured out the basics, such as time travel. Give it time to solidify before going after the base semantics. The structure is going to change drastically very soon (once #4717 or something like it lands).

@DimitryDushkin
Copy link
Author

Oh, I see. Thank you.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants