Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial "@@router/LOCATION_CHANGE" action #5038

Closed
DimitryDushkin opened this issue Apr 26, 2017 · 3 comments
Closed

Remove initial "@@router/LOCATION_CHANGE" action #5038

DimitryDushkin opened this issue Apr 26, 2017 · 3 comments

Comments

@DimitryDushkin
Copy link

DimitryDushkin commented Apr 26, 2017

On ConnectedRouter (from react-router-redux) initialization action @@router/LOCATION_CHANGE is fired with current path as payload.

I think this behaviour is misleading because no actual location change is happening.

If this behaviour is needed to fill state with initial data I suggest to rename it to something like @@router/LOCATION_INIT.

Version

4.0.0

@timdorr
Copy link
Member

timdorr commented Apr 26, 2017

A location change is happening, just outside the context of your application. It's going from about:blank to whatever URL it loads up as. There's nothing special about this.

@timdorr timdorr closed this as completed Apr 26, 2017
@DimitryDushkin
Copy link
Author

And if I just refresh page? Location is not changed.

@DimitryDushkin
Copy link
Author

Also native history api do not demonstrate such behavior.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants