Skip to content

Commit

Permalink
ci: uppercase ENV, changesets output is camelCase (#10036)
Browse files Browse the repository at this point in the history
Signed-off-by: Logan McAnsh <[email protected]>
  • Loading branch information
mcansh authored Feb 2, 2023
1 parent d6fbfab commit a579835
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
if: github.repository == 'remix-run/react-router'
runs-on: ubuntu-latest
outputs:
published_packages: ${{ steps.changesets.outputs.published_packages }}
published_packages: ${{ steps.changesets.outputs.publishedPackages }}
published: ${{ steps.changesets.outputs.published }}
steps:
- name: 🛑 Cancel Previous Runs
Expand Down Expand Up @@ -83,15 +83,15 @@ jobs:
package_version=$(node ./scripts/release/find-release-from-changeset.js)
echo "package_version=${package_version}" >> $GITHUB_OUTPUT
env:
package_version_to_follow: "react-router"
published_packages: ${{ needs.release.outputs.published_packages }}
PACKAGE_VERSION_TO_FOLLOW: "react-router"
PUBLISHED_PACKAGES: ${{ needs.release.outputs.published_packages }}

comment:
name: 📝 Comment on related issues and pull requests
if: github.repository == 'remix-run/react-router' && needs.find_package_version.outputs.packageVersion != ''
needs: [release, find_package_version]
uses: ./.github/workflows/release-comments.yml
with:
ref: refs/tags/remix@${{ needs.find_package_version.outputs.packageVersion }}
ref: refs/tags/react-router@${{ needs.find_package_version.outputs.packageVersion }}
package_version_to_follow: "react-router"
release_branch: ${{ github.ref_name }}
4 changes: 2 additions & 2 deletions scripts/release/find-release-from-changeset.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ function findReleaseFromChangeset(publishedPackages, packageVersionToFollow) {
}

findReleaseFromChangeset(
process.env.published_packages,
process.env.package_version_to_follow
process.env.PUBLISHED_PACKAGES,
process.env.PACKAGE_VERSION_TO_FOLLOW
);

0 comments on commit a579835

Please sign in to comment.