feat: mutable route tree (#9996)

* initial work + test outline * wip: addRoute,updateRoute,deleteRoute * refactor(hmr): internal api for updating routes and revalidating * refactor: _internalSetRoutes * test: update method name after rename * revalidate in tests * chore: remove data for routes with no loader test: cover navigation interruption * add changeset * Add a couple more tests * Fix invalid useRouteLoaderData test * Handle HMR use cases for revalidating fetchers * Bump bundle --------- Co-authored-by: Pedro Cattori <[email protected]> Co-authored-by: Matt Brophy <[email protected]>
remix-run · Feb 21, 2023 · 3eac3a6 · 3eac3a6
1 parent bbe4ec5
commit 3eac3a6
Show file tree

Hide file tree

Showing 6 changed files with 561 additions and 61 deletions.
diff --git a/.changeset/quick-yaks-join.md b/.changeset/quick-yaks-join.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/router": patch
+---
+
+Add internal API for custom HMR implementations
diff --git a/package.json b/package.json
@@ -105,7 +105,7 @@
   },
   "filesize": {
     "packages/router/dist/router.umd.min.js": {
-      "none": "41.5 kB"
+      "none": "41.6 kB"
     },
     "packages/react-router/dist/react-router.production.min.js": {
       "none": "13 kB"

diff --git a/packages/react-router-dom/server.tsx b/packages/react-router-dom/server.tsx
@@ -307,6 +307,9 @@ export function createStaticRouter(
     },
     _internalFetchControllers: new Map(),
     _internalActiveDeferreds: new Map(),
+    _internalSetRoutes() {
+      throw msg("_internalSetRoutes");
+    },
   };
 }
 

diff --git a/packages/react-router/__tests__/data-memory-router-test.tsx b/packages/react-router/__tests__/data-memory-router-test.tsx
@@ -821,7 +821,6 @@ describe("<DataMemoryRouter>", () => {
         initialEntries={["/foo"]}
         hydrationData={{
           loaderData: {
-            layout: null,
             foo: "FOO",
           },
         }}
@@ -861,7 +860,7 @@ describe("<DataMemoryRouter>", () => {
     }
 
     expect(spy).toHaveBeenCalledWith({
-      layout: null,
+      layout: undefined,
       foo: "FOO",
       bar: undefined,
       child: undefined,
@@ -896,7 +895,7 @@ describe("<DataMemoryRouter>", () => {
       </div>"
     `);
     expect(spy).toHaveBeenCalledWith({
-      layout: null,
+      layout: undefined,
       foo: undefined,
       bar: undefined,
       child: "CHILD",