test(core): add failing test to generatePath, see #6171 (#6172)

* test(core): add failing test to generatePath, see #6171 * fix(typo): fix typo on test * Use the pretty option. * Pretty in compiled function
remix-run · May 25, 2018 · 34412fd · 34412fd
1 parent 6ae433a
commit 34412fd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/react-router/modules/__tests__/generatePath-test.js b/packages/react-router/modules/__tests__/generatePath-test.js
@@ -53,4 +53,16 @@ describe("generatePath", () => {
       expect(generated).toBe("/");
     });
   });
+
+  describe('simple pattern="/view/:id"', () => {
+    it("handle = on params", () => {
+      const pattern = "/view/:id";
+      const params = { id: "Q29tcGxhaW50OjVhZjFhMDg0MzhjMTk1MThiMTdlOTQ2Yg==" };
+
+      const generated = generatePath(pattern, params);
+      expect(generated).toBe(
+        "/view/Q29tcGxhaW50OjVhZjFhMDg0MzhjMTk1MThiMTdlOTQ2Yg=="
+      );
+    });
+  });
 });
diff --git a/packages/react-router/modules/generatePath.js b/packages/react-router/modules/generatePath.js
@@ -28,7 +28,7 @@ const generatePath = (pattern = "/", params = {}) => {
     return pattern;
   }
   const generator = compileGenerator(pattern);
-  return generator(params);
+  return generator(params, { pretty: true });
 };
 
 export default generatePath;