Removed unnecessary className on Link (#3288)

remix-run · Apr 13, 2016 · 0a42723 · 0a42723
1 parent 46d29e6
commit 0a42723
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/modules/Link.js b/modules/Link.js
@@ -66,7 +66,6 @@ const Link = React.createClass({
   getDefaultProps() {
     return {
       onlyActiveOnIndex: false,
-      className: '',
       style: {}
     }
   },
@@ -119,7 +118,7 @@ const Link = React.createClass({
       if (activeClassName || (activeStyle != null && !isEmptyObject(activeStyle))) {
         if (router.isActive(location, onlyActiveOnIndex)) {
           if (activeClassName)
-            props.className += props.className === '' ? activeClassName : ` ${activeClassName}`
+            props.className = `${props.className || ''} ${activeClassName}`.trim()
 
           if (activeStyle)
             props.style = { ...props.style, ...activeStyle }

diff --git a/modules/__tests__/Link-test.js b/modules/__tests__/Link-test.js
@@ -29,6 +29,15 @@ describe('A <Link>', function () {
     node = document.createElement('div')
   })
 
+  it('should not render unnecessary class=""', function () {
+    render((
+      <Link to="/something" />
+    ), node, function () {
+      const a = node.querySelector('a')
+      expect(a.hasAttribute('class')).toBe(false)
+    })
+  })
+
   it('knows how to make its href', function () {
     class LinkWrapper extends Component {
       render() {