Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite3 CLI #44

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add sqlite3 CLI #44

merged 3 commits into from
Apr 1, 2022

Conversation

mrkurt
Copy link
Contributor

@mrkurt mrkurt commented Apr 1, 2022

This adds the sqlite3 CLI to the build, and generates a shortcut for connecting to the database. It will work in any Docker environment.

To connect to sqlite in a running Docker container, run docker exec -ti <container> database-cli.

On Fly.io, you can run fly ssh console -C database-cli.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds cool! Mind making this change to the Blues Stack as well?

Dockerfile Show resolved Hide resolved
@mrkurt
Copy link
Contributor Author

mrkurt commented Apr 1, 2022

We're looking at the blues stack! It's a little harder, and we have fly pg connect -a <db-name> for this reason. I think we may be able to make fly pg connect work by default from the app directory. I'll add instructions at least.

@mrkurt
Copy link
Contributor Author

mrkurt commented Apr 1, 2022

@kentcdodds one other thing: I moved the env vars from fly.toml into the Dockerfile. This makes the Dockerfile more useful outside the Fly.io environment. It also made it easier to test this change. :)

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for these improvements 👏

@kentcdodds kentcdodds merged commit d51a99c into remix-run:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants