Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make seeding happen only once for Cypress in Github Actions #33

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

na2hiro
Copy link
Contributor

@na2hiro na2hiro commented Mar 26, 2022

Currently Cypress task for the deploy Github Action runs them in a row:

  • npx prisma migrate reset --force
  • npx prisma db seed

Because prisma migrate reset also runs seed command, it could fail if the seed script inserts with unique keys specified for example:

Screen Shot 2022-03-26 at 17 39 05

We should remove explicit npx prisma db seed there so seed runs only once.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit bff6bd2 into remix-run:main Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants