Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully automate developer setup with Gitpod #72

Closed
wants to merge 2 commits into from

Conversation

jacobparis
Copy link
Contributor

I've added Gitpod support to the Grunge Stack (here is a similar PR for the Indie Stack remix-run/indie-stack#58)

When a user clicks the Gitpod button, they'll get a workspace with the environment variables set, Fly pre-installed, and the Postgres database running in Docker Compose ready to go. The application starts immediately and a user can create an account and add notes right away.

cc @MichaelDeBoey remix-run/blues-stack#58 (comment)

You can test this workflow by clicking this button:

Gitpod Ready-to-Code

Comment on lines +87 to +91
- VisualStudioExptTeam.vscodeintellicode
- dbaeumer.vscode-eslint
- formulahendry.auto-rename-tag
- esbenp.prettier-vscode
- ms-azuretools.vscode-docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the following extensions in the other stacks.
Should we have the same as we have there?
Or should we update the other stacks instead?

    - ms-azuretools.vscode-docker
    - esbenp.prettier-vscode
    - dbaeumer.vscode-eslint
    - bradlc.vscode-tailwindcss

##
## Learn more at 'https://www.gitpod.io/docs/prebuilds'

github:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this section in the other stacks.
Should we remove it here & keep it like we have there?
Or should we update the other stacks instead?

@@ -0,0 +1,115 @@
## Learn more about this file at 'https://www.gitpod.io/docs/references/gitpod-yml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what to do with these comments tbh.

They're giving some extra context, which is a good thing imo.
But it's also making the file more verbose I think.

If we decide to keep the comments, I think we should add them in the other stacks as well, so we keep this file the same on all our stacks.

ports:
- port: 3000 # alternatively configure entire ranges via '8080-8090'
visibility: private # either 'public' or 'private' (default)
onOpen: open-browser # either 'open-browser', 'open-preview' or 'ignore'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set to notify in the other stacks.
According to the comment, this is an invalid value.
Should we update the other stacks?

@MichaelDeBoey
Copy link
Member

@jacobparis Could you please rebase your branch onto latest main & resolve conversations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants