feat: enable v2_dev flag
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
requested review from
machour,
markdalgleish,
pcattori and
brophdawg11
pcattori
requested changes
Jul 7, 2023
MichaelDeBoey
commented
Jul 7, 2023
package.json
Outdated
| @@ -6,10 +6,8 @@ | |||
| "build": "run-s build:*", | |||
| "build:remix": "remix build", | |||
| "build:server": "esbuild --platform=node --format=cjs ./server.ts --outdir=build --bundle", | |||
There was a problem hiding this comment.
@pcattori Do we still need to build the server like this?
I guess we mainly did it to be used in the dev script 🤔
There was a problem hiding this comment.
still needed as this repo authors the custom server in TS and does not use remix.config.js's server field to compile the custom server.
There was a problem hiding this comment.
@pcattori Should we use remix.config.js instead?
server.ts
Outdated
|
|
||
| const BUILD_PATH = path.join(process.cwd(), "build", "index.js"); | ||
| /** @type { import('@remix-run/node').ServerBuild | Promise<import('@remix-run/node').ServerBuild> } */ | ||
| let build = await import(BUILD_PATH); |
There was a problem hiding this comment.
Top level await is failing with following TS error
@pcattori Not sure what the right way would be as we're still officially supporting Node 14
There was a problem hiding this comment.
for now I just wrapped this in a async function run() {...}
MichaelDeBoey
force-pushed
the
enable-v2_dev-flag
branch
5 times, most recently
from
b74d156 to
88d8d8f
Compare
MichaelDeBoey
force-pushed
the
enable-v2_dev-flag
branch
from
88d8d8f to
db89938
Compare
MichaelDeBoey
force-pushed
the
enable-v2_dev-flag
branch
from
db89938 to
d68458b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.