Skip to content

Commit

Permalink
feat: add playwright container (#167)
Browse files Browse the repository at this point in the history
## Context

This PR will use the playwright container instead of installing the
dependencies on the pipeline

## Changes

- Added: container to workflow

## Checklist

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] I have tested my code for breaking changes and added the
corresponding footer in this PR if needed
- [x] I have added tests that prove my fix is effective or that my
feature works
  • Loading branch information
remcolakens authored Jan 30, 2025
1 parent fa84ead commit 18cf12e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ jobs:
max_timeout: 600

test_e2e:
name: Test e2e
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.50.0-noble
needs: test_setup
timeout-minutes: 60
steps:
Expand All @@ -38,16 +41,14 @@ jobs:
- name: Setup
uses: ./.github/actions/setup

- name: Install Playwright browsers
run: pnpm exec playwright install --with-deps

- name: Run tests
run: pnpm test:e2e
env:
PLAYWRIGHT_TEST_BASE_URL: ${{ needs.test_setup.outputs.preview_url }}
HOME: /root

- name: Upload test results
if: always() && !cancelled()
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: playwright-test-results
Expand Down

0 comments on commit 18cf12e

Please sign in to comment.