Publish to VS Marketplace #40

asbjornu · 2021-03-16T13:21:20Z

Tweaks the GitHub Actions workflow to publish the extension to the VS Marketplace.

Resolves #38.

@mrmlnc

Update package.json metadata to reflect the move from @mrmlnc to @remarkjs.

Modify the GitHub Actions workflow by adding: - gitversion job - setup-node step - version step - cache step - publish step

wooorm · 2021-03-16T15:02:40Z

nice!

asbjornu · 2021-03-17T00:51:26Z

@wooorm, I need to add a Personal Access Token or have one of you create one and add it as the GitHub secret VSCE_TOKEN. Secrets are only available for repository administrators.

wooorm · 2021-03-17T08:58:28Z

It looks like an azure org is needed for that? So that is a different one from unifiedjs on the marketplace? And I need to set that up?

asbjornu · 2021-03-17T10:33:33Z

It looks like an azure org is needed for that?

Yes, I've created unifiedjs on Azure DevOps and invited you, @ChristianMurphy and @JounQin to it.

So that is a different one from unifiedjs on the marketplace?

Pretty silly, but yes. 🙄

And I need to set that up?

No, I have.

wooorm · 2021-03-17T10:48:04Z

🤷‍♂️

asbjornu · 2021-03-17T10:57:28Z

I think you should receive an e-mail invitation you need to accept, @wooorm.

asbjornu · 2021-03-18T23:53:03Z

Thank you so much for the code review, @joebowbeer! It still fails, however:

npm ERR! code E401
npm ERR! Unable to authenticate, need: Basic realm="GitHub Package Registry"

Ideas?

joebowbeer

See suggested change.

.github/workflows/build.yml

Co-authored-by: Joe Bowbeer <[email protected]>

joebowbeer

The current version might be as good as it gets without editing package.json.

But this is one more thing to try.

However, I'm rethinking my assumption that this is possible without editing package.json.

The published package includes package.json. Having a package published as scoped claim in its package.json that it is unscoped may be troublesome.

.github/workflows/build.yml

wooorm · 2021-03-19T07:15:48Z

You're there, but it doesn't look like you've accepted the invitation.

No, the Microsoft communication was to have you added to the VSCE Marketplace. That's all done and seems to be working now.

When I accept, I get that 401 from #40 (comment).
I believe Joun was getting the same results.
As I can’t get in there, and the Get a PAT link you shared requires an org, that’s why I thought I had to create a throwaway one

Co-authored-by: Joe Bowbeer <[email protected]>

asbjornu · 2021-03-19T08:19:09Z

When I accept, I get that 401 from #40 (comment).

It's really stupid, but as explained in this Stack Overflow answer, please try to open unifiedjs in an incognito Window or a separate browser and sign in with the invited e-mail address.

As I can’t get in there, and the Get a PAT link you shared requires an org, that’s why I thought I had to create a throwaway one

Yeah, I get it. I just can't yet accept that Azure DevOps is so useless that it's impossible to invite users to the organization. Let's please give this another go.

asbjornu · 2021-03-19T08:34:30Z

But this is one more thing to try.

Thanks, @joebowbeer! It still fails, unfortunately:

npm ERR! code E404
npm ERR! 404 Not Found - PUT https://npm.pkg.github.com/vscode-remark

However, I'm rethinking my assumption that this is possible without editing package.json.

The published package includes package.json. Having a package published as scoped claim in its package.json that it is unscoped may be troublesome.

Yeah, that makes sense. Sad that unscoped packages aren't supported by GPR, though.

wooorm · 2021-03-20T08:51:53Z

Yeah, I get it. I just can't yet accept that Azure DevOps is so useless that it's impossible to invite users to the organization. Let's please give this another go.

I tried again. Private window. And different browser. To no avail.
It might be that my account is connected through GH.

I also got this one, weirdly. But I solved that by adding a phone number:

It’s unrelated to these codes, right? #28 (comment)

Could you maybe remove me from the org, and add me again? (i.e., the age old: have you tried turning it off and on again 😅)
Edit: and it seems that it might work: https://developercommunity.visualstudio.com/t/github-login-fails-with-tf400813-the-user-windows/1141626#T-N1144704

asbjornu · 2021-03-20T13:40:29Z

It’s unrelated to these codes, right? #28 (comment)

Yes, those codes were used to have you invited to the VSCE Marketplace.

Could you maybe remove me from the org, and add me again? (i.e., the age old: have you tried turning it off and on again 😅)

Sure, I've just removed and added you back to the organization. I hope that helps! 🤞🏼

wooorm · 2021-03-20T15:24:20Z

Sure, I've just removed and added you back to the organization. I hope that helps! 🤞🏼

It didn’t 😭

wooorm · 2021-03-20T15:28:17Z

Meanwhile, to get this unblocked, I’m guessing that you can create such a token and I can add it. Could you DM/email me one?

asbjornu · 2021-03-20T18:36:05Z

Sure, I've just removed and added you back to the organization. I hope that helps! 🤞🏼

It didn’t 😭

😭

Meanwhile, to get this unblocked, I’m guessing that you can create such a token and I can add it. Could you DM/email me one?

Sure, I'll pop you an e-mail.

…s to GPR

.github/gitversion.yml

.github/workflows/build.yml

JounQin · 2021-03-22T02:45:37Z

@wooorm Did you add the VSCE_TOKEN to vscode-mdx too?

wooorm · 2021-03-22T09:33:41Z

I just added a VSCE_TOKEN token there

Update package.json metadata

0ceb1c6

Update package.json metadata to reflect the move from @mrmlnc to @remarkjs.

asbjornu force-pushed the feature/gh-38_vs_marketplace branch 9 times, most recently from cf73e1e to b0127ef Compare March 16, 2021 14:12

Add publish step to the GitHub Actions workflow

c31053d

Modify the GitHub Actions workflow by adding: - gitversion job - setup-node step - version step - cache step - publish step

asbjornu force-pushed the feature/gh-38_vs_marketplace branch from b0127ef to c31053d Compare March 16, 2021 14:23

Add @remarkjs scope

b930e90

Base automatically changed from master to main March 16, 2021 15:28

asbjornu added 2 commits March 16, 2021 19:54

Use npm version instead of jq

fd8f20e

Set GitVersion to mode ContinuousDeployment

cd54bc8

asbjornu force-pushed the feature/gh-38_vs_marketplace branch from 7fc923d to 529f8ed Compare March 17, 2021 00:23

Separate publish-gpr to its own job

1fbdb3f

asbjornu force-pushed the feature/gh-38_vs_marketplace branch from 529f8ed to 1fbdb3f Compare March 17, 2021 00:31

Ignore .vsix files

51642f7

asbjornu force-pushed the feature/gh-38_vs_marketplace branch 4 times, most recently from 75654d4 to df913db Compare March 17, 2021 02:19

joebowbeer suggested changes Mar 19, 2021

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

Remove @remarkjs from the authentication string

1c64975

Co-authored-by: Joe Bowbeer <[email protected]>

joebowbeer suggested changes Mar 19, 2021

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

Remove scope from npm registry

8fb34f1

Co-authored-by: Joe Bowbeer <[email protected]>

asbjornu added 5 commits March 20, 2021 20:22

Remove publish-gpr as it seems impossible to publish unscoped package…

6b13abd

…s to GPR

Change publish workflow to only trigger on release publish

93f478e

Run vsce package on build as well

8b0d865

Don't run vsce-package on Windows

2c0b298

Move package to its own job and remove gitversion from build

a5b6354

asbjornu marked this pull request as ready for review March 20, 2021 22:31

asbjornu requested a review from wooorm March 20, 2021 22:31

Run npm build on package as well

16a9fe2

wooorm reviewed Mar 21, 2021

View reviewed changes

.github/gitversion.yml Show resolved Hide resolved

.github/workflows/build.yml Outdated Show resolved Hide resolved

Remove whitespace from GitHub Actions expressions

70955f9

wooorm approved these changes Mar 21, 2021

View reviewed changes

asbjornu merged commit abcb185 into main Mar 21, 2021

asbjornu deleted the feature/gh-38_vs_marketplace branch March 21, 2021 15:09

asbjornu mentioned this pull request Mar 21, 2021

Publish the extension to OpenVSX #31

Closed

JounQin mentioned this pull request Jul 11, 2022

ci: add publish workflow for releasing on CI automatically mdx-js/mdx-analyzer#207

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish to VS Marketplace #40

Publish to VS Marketplace #40

asbjornu commented Mar 16, 2021 •

edited

Loading

wooorm commented Mar 16, 2021

asbjornu commented Mar 17, 2021 •

edited

Loading

wooorm commented Mar 17, 2021

asbjornu commented Mar 17, 2021

wooorm commented Mar 17, 2021

asbjornu commented Mar 17, 2021

asbjornu commented Mar 18, 2021

joebowbeer left a comment

joebowbeer left a comment

wooorm commented Mar 19, 2021 •

edited

Loading

asbjornu commented Mar 19, 2021 •

edited

Loading

asbjornu commented Mar 19, 2021 •

edited

Loading

wooorm commented Mar 20, 2021 •

edited

Loading

asbjornu commented Mar 20, 2021

wooorm commented Mar 20, 2021

wooorm commented Mar 20, 2021

asbjornu commented Mar 20, 2021 •

edited

Loading

JounQin commented Mar 22, 2021

wooorm commented Mar 22, 2021

Publish to VS Marketplace #40

Publish to VS Marketplace #40

Conversation

asbjornu commented Mar 16, 2021 • edited Loading

wooorm commented Mar 16, 2021

asbjornu commented Mar 17, 2021 • edited Loading

wooorm commented Mar 17, 2021

asbjornu commented Mar 17, 2021

wooorm commented Mar 17, 2021

asbjornu commented Mar 17, 2021

asbjornu commented Mar 18, 2021

joebowbeer left a comment

Choose a reason for hiding this comment

joebowbeer left a comment

Choose a reason for hiding this comment

wooorm commented Mar 19, 2021 • edited Loading

asbjornu commented Mar 19, 2021 • edited Loading

asbjornu commented Mar 19, 2021 • edited Loading

wooorm commented Mar 20, 2021 • edited Loading

asbjornu commented Mar 20, 2021

wooorm commented Mar 20, 2021

wooorm commented Mar 20, 2021

asbjornu commented Mar 20, 2021 • edited Loading

JounQin commented Mar 22, 2021

wooorm commented Mar 22, 2021

asbjornu commented Mar 16, 2021 •

edited

Loading

asbjornu commented Mar 17, 2021 •

edited

Loading

wooorm commented Mar 19, 2021 •

edited

Loading

asbjornu commented Mar 19, 2021 •

edited

Loading

asbjornu commented Mar 19, 2021 •

edited

Loading

wooorm commented Mar 20, 2021 •

edited

Loading

asbjornu commented Mar 20, 2021 •

edited

Loading