Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to vfile messages #71

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Add url to vfile messages #71

merged 2 commits into from
Aug 25, 2022

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This enhances the user experience in editors by adding a link to the project and providing the suggestion as a quick fix.

These are two separate features, but I combined them, because they touch the same lines.

This enhances the user experience in editors.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 22, 2022
lib/check/validate.js Outdated Show resolved Hide resolved
@remcohaszing remcohaszing changed the title Add url and expected to vfile messages Add url to vfile messages Aug 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #71 (6c5c05f) into main (5a2641a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          875       880    +5     
=========================================
+ Hits           875       880    +5     
Impacted Files Coverage Δ
lib/check/validate.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wooorm wooorm changed the title Add url to vfile messages Add url to vfile messages Aug 25, 2022
@wooorm wooorm merged commit 53b0c24 into remarkjs:main Aug 25, 2022
@wooorm wooorm added 🦋 type/enhancement This is great to have 💪 phase/solved Post is done labels Aug 25, 2022
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 25, 2022
@wooorm
Copy link
Member

wooorm commented Aug 25, 2022

released in 12.1.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

5 participants