Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragments should be case-insensitive #41

Closed
pajachiet opened this issue Jun 21, 2019 · 2 comments
Closed

Fragments should be case-insensitive #41

pajachiet opened this issue Jun 21, 2019 · 2 comments
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@pajachiet
Copy link

Subject of the issue

remark-validate-links should authorize uppercase headings.

Currently, it authorize uppercase or mixed case link to files, but breaks for headings.

URL should be generally treated as case insensitive (cf comment).

Your environment

  • OS: MacOs
  • Packages:
    "dependencies": {
    "remark": "^10.0.1",
    "remark-cli": "^6.0.1",
    "remark-lint": "^6.0.4",
    "remark-lint-no-dead-urls": "^0.4.1",
    "remark-validate-links": "^8.0.0",
    "vuepress": ">= v1.0.0-alpha.47"
    },
@wooorm
Copy link
Member

wooorm commented Jun 22, 2019

Could you provide an example of actual behaviour and expected behaviour? Such as, some Markdown?

@wooorm wooorm closed this as completed in 0c45387 Jun 23, 2019
wooorm added a commit that referenced this issue Jun 23, 2019
@wooorm
Rewrite module
87186af 
* Use async file system operations
* Check definitions, not references
* Get repo info from Git instead of `package.json`, supporting non-npm projects
* Support checking files on the API
* Support non-hosted Git repos
* Support self-hosted Git repos
* Support case-insensitive hashes
* Support streaming
* Support multiple Git repos
* Supports Gists
* Add many more tests

Closes GH-28.
Closes GH-39.
Closes GH-41.
@pajachiet
Copy link
Author

Sorry for the absence of example. I can see you already fixed it. Thanks a lot ! 🙏

@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface labels Aug 15, 2019
@wooorm wooorm changed the title Allow mixed case for headings Fragments should be case-insensitive Aug 15, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooorm @pajachiet