Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tight mode was failing for heading levels greater than 2 #8

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Dec 20, 2016

This PR updates the test case to fail with the current version of mdast-util-toc.
I've already opened a PR against mdast-util-toc to fix the issue: syntax-tree/mdast-util-toc#3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
@wooorm
Copy link
Member

wooorm commented Dec 20, 2016

Cool, thanks. I’ll merge this once @BarryThePenguin publishes a new release!

Thanks for finding this!

@gkatsev
Copy link
Contributor Author

gkatsev commented Dec 20, 2016

Happy to help!

@BarryThePenguin
Copy link
Member

BarryThePenguin commented Dec 20, 2016

published

heads up though, I'm gonna release v3 and drop node v0.10 support similar to remark-toc

scrap that... just dropping support in travis, nothing in the package needs to change. v2.0.1 it is 👍

@wooorm wooorm merged commit e485682 into remarkjs:master Dec 21, 2016
@wooorm
Copy link
Member

wooorm commented Dec 21, 2016

Thanks both!

@gkatsev gkatsev deleted the more-levels branch December 21, 2016 15:26
@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface labels Aug 14, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants