-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useRemarkSync
param type
#74
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Welcome @karlhorky 👋 |
To your CI/CD comment, I think |
I'm sorry. Was definitely not my intention to cause any stress or be aggressive and I'd like to understand more to improve. I'll try reaching out privately on Twitter/X/email. |
Added a step in 0607f10 (Made it a separate step to make it easier to delete later, with less noise in Git blame) |
Glad to see see again @karlhorky! The changes look good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karlhorky
Glad to help, thanks for the reviews! If there's anything else I should do to get this merged, let me know :) |
Initial checklist
Description of changes
It looks like #18 used the
UseRemarkOptions
type instead of theUseRemarkSyncOptions
type for the 2nd parameter of theuseRemarkSync()
function:It seems incorrect to me because of A) the name and B) the
onError
property not being used.