Bmp280 example #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu91
reviewed
Aug 18, 2021
|
|
||
| updates: dh, kg 2018 | ||
| */ | ||
|
|
There was a problem hiding this comment.
Why removing this header description? Can't you just update it?
There was a problem hiding this comment.
I am going to write a full markdown file on this.
There was a problem hiding this comment.
Do you want to do that in a subsequent PR? if so I'll add an issue after merging.
There was a problem hiding this comment.
Yes, already created an issue for that.
#9
examples/BME280/BME280.ino
Outdated
|
|
||
| // connected, make the LED stay on | ||
| digitalWrite(LED_BUILTIN, PIN_STATE_HIGH); | ||
| //digitalWrite(LED_BUILTIN, PIN_STATE_HIGH); |
There was a problem hiding this comment.
Why don't we keep this visual feedback?
There was a problem hiding this comment.
Fair enough. Don't remember why I commented it out ^^
relu91
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the BMP280 example.