Allow specifying block response in configuration #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. Is there anything else you were planning to do since it is marked as draft or should we merge it? |
|
I need to update the examples and then give this a look over with some fresh eyes! Should be ready shortly. |
mutemule
force-pushed
the
error_code_configuration
branch
from
d319d90 to
ab632b6
Compare
|
Added a couple of tests to check failure modes, which wound up finding a problem ( |
NXDOMAIN is the traditional response code for blocking DNS queries, but can make it difficult to differentiate between actual DNS problems and DNS blocklists. This change introduces the ability to respond with REFUSED instead, to make it easier to identify DNS blocks. The default behaviour remains to respond with NXDOMAIN, so no additional configuration is required to maintain current behaviour.
mutemule
force-pushed
the
error_code_configuration
branch
from
ab632b6 to
5f0f6e7
Compare
|
Nice 👍 |
|
I forgot to tag it after it was merged, but it is tagged and built now: v1.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NXDOMAIN is the traditional response code for blocking DNS queries, but can make it difficult to differentiate between actual DNS problems and DNS blocklists. This change introduces the ability to respond with REFUSED instead, to make it easier to identify DNS blocks.
The default behaviour remains to respond with NXDOMAIN, so no additional configuration is required to maintain current behaviour.