Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use whatBump option #106

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

davidlj95
Copy link
Contributor

@davidlj95 davidlj95 commented Nov 9, 2024

In #102 whatBump option was introduced to provide a custom way to recommend the version to bump. By passing it to bumper.bump. But if none was provided, then it failed. In #105 it was fixed so that if none is provided, the preset one is used. However now it's not used anymore if provided.

Fixing this by using the given whatBump in case it's a function. Done the TDD-way.

Btw found it curious conventional commits aren't used for this repo's commits. En casa de herrero, cuchara de palo as we'd say in Spain 😛

@webpro
Copy link
Contributor

webpro commented Nov 9, 2024

Btw found it curious conventional commits aren't used for this repo's commits. En casa de herrero, cuchara de palo as we'd say in Spain 😛

That's an issue indeed. At some point I decided it was a good idea to split release-it core and have plugins like this. I'd normally dogfood whenever I can, but also I do my releases without this convention, so here we are 😃 #104

Will look into the PR tomorrow, thanks for that!

Copy link

pkg-pr-new bot commented Nov 11, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/@release-it/[email protected]

commit: 7e05eae

@webpro webpro merged commit 09aac9e into release-it:master Nov 11, 2024
11 checks passed
@webpro
Copy link
Contributor

webpro commented Nov 11, 2024

Thank you @davidlj95! Good stuff, no notes :)

@davidlj95 davidlj95 deleted the fix-use-whatbump-opt branch November 11, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants