Fix buildah retry mechanism #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
previously approved these changes
Jun 5, 2024
xDaile
force-pushed
the
buildah_retry_fix
branch
5 times, most recently
from
773a54d to
34b3ee6
Compare
lipoja
approved these changes
Jun 10, 2024
JAVGan
approved these changes
Jun 10, 2024
chandwanitulsi
approved these changes
Jun 10, 2024
xDaile
force-pushed
the
buildah_retry_fix
branch
from
34b3ee6 to
5ab3dc8
Compare
lslebodn
reviewed
Jun 11, 2024
| network_regexes = [ | ||
| r'.*([e,E]rror:? creating build container).*(:?(50[0-9]|125)\s.*$)', | ||
| r'.*(read\/write on closed pipe.*$)', | ||
| ] |
There was a problem hiding this comment.
Have you considered to get regular expressions from config file?
So one needn't deploy new version of IIB just to retry new network issue reported by buildah
There was a problem hiding this comment.
@lipoja what do you think?
IMO those network issues error messages are not changing that fast, so we would need to have that in config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOUDDST-22677
CLOUDDST-21131
Buildah retry mechanism fix: