-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support of multiple operators in one fragment #660
Merged
lipoja
merged 1 commit into
release-engineering:master
from
lipoja:fbc_multiple_operators
Apr 17, 2024
Merged
Adding support of multiple operators in one fragment #660
lipoja
merged 1 commit into
release-engineering:master
from
lipoja:fbc_multiple_operators
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
requested review from
JAVGan,
chandwanitulsi,
yashvardhannanavati and
xDaile
April 9, 2024 10:43
JAVGan
previously approved these changes
Apr 10, 2024
yashvardhannanavati
previously approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions, overall LGTM
lipoja
force-pushed
the
fbc_multiple_operators
branch
2 times, most recently
from
April 15, 2024 06:12
d3d88a3
to
5fbb253
Compare
Rebased and added @chandwanitulsi suggestions. |
yashvardhannanavati
force-pushed
the
fbc_multiple_operators
branch
from
April 16, 2024 12:47
5fbb253
to
312d0cb
Compare
yashvardhannanavati
previously approved these changes
Apr 16, 2024
lipoja
force-pushed
the
fbc_multiple_operators
branch
2 times, most recently
from
April 16, 2024 14:14
499357d
to
f639d48
Compare
chandwanitulsi
approved these changes
Apr 16, 2024
yashvardhannanavati
approved these changes
Apr 17, 2024
[CLOUDDST-22242]
yashvardhannanavati
force-pushed
the
fbc_multiple_operators
branch
from
April 17, 2024 05:15
f639d48
to
a026b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support of multiple operators in one FBC fragment.
[CLOUDDST-22242]