Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding graph update mode for merge index image API endpoint #578

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Adding graph update mode for merge index image API endpoint #578

merged 2 commits into from
Oct 30, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Oct 17, 2023

[CLOUDDST-20163]

@lipoja lipoja force-pushed the mode_merge branch 5 times, most recently from 1423a59 to 8512d07 Compare October 17, 2023 14:03
xDaile
xDaile reviewed Oct 17, 2023
View reviewed changes
iib/web/iib_static_types.py Outdated Show resolved Hide resolved
@lipoja lipoja force-pushed the mode_merge branch 4 times, most recently from 4f578b4 to 93111a8 Compare October 18, 2023 07:53
@lipoja lipoja requested a review from xDaile October 18, 2023 07:54
@lipoja lipoja force-pushed the mode_merge branch 2 times, most recently from 0c9d184 to 71d0d81 Compare October 18, 2023 08:33
xDaile
xDaile previously approved these changes Oct 18, 2023
View reviewed changes
JAVGan
JAVGan reviewed Oct 18, 2023
View reviewed changes
iib/web/iib_static_types.py Outdated Show resolved Hide resolved
JAVGan
JAVGan reviewed Oct 18, 2023
View reviewed changes
iib/web/iib_static_types.py Outdated Show resolved Hide resolved
JAVGan
JAVGan previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JAVGan JAVGan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the fix for the first commit in the second one everything else LGTM

@lipoja lipoja requested review from JAVGan and a team October 19, 2023 13:04
@lipoja lipoja dismissed stale reviews from xDaile and JAVGan via f7273d4 October 25, 2023 08:52
@lipoja lipoja merged commit 5454ef3 into release-engineering:master Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDaile xDaile xDaile approved these changes

@chandwanitulsi chandwanitulsi chandwanitulsi approved these changes

@JAVGan JAVGan JAVGan approved these changes

@yashvardhannanavati yashvardhannanavati Awaiting requested review from yashvardhannanavati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lipoja @JAVGan @chandwanitulsi @xDaile