Improve PHPUnit fixture

[peter279k]

Changed log

• According to the PHPUnit doc, it should be protected function setUp() : void and protected function tearDown() : void.

[cxj]

This needs to have a custom config setting for php.ini added to the Travis set up in .travis.yml to enable code coverage checks to work correctly. It nees to set 'xdebug.mode' to 'coverage'. More information on how to do that is here: https://docs.travis-ci.com/user/languages/php/#custom-php-configuration

[peter279k]

This needs to have a custom config setting for php.ini added to the Travis set up in .travis.yml to enable code coverage checks to work correctly. It nees to set 'xdebug.mode' to 'coverage'. More information on how to do that is here: https://docs.travis-ci.com/user/languages/php/#custom-php-configuration

Thanks. It's fixed now :).

[cxj]

This now fails checks by Psalm, due to a Symfony polyfill's usage of the null coalescing assignment operator ??= which was introduced in PHP 7.4. Here is the error message for convenience:

ERROR: ParseError - vendor/symfony/polyfill-mbstring/bootstrap80.php:125:88 - Syntax error, unexpected '=' on line 125 (see https://psalm.dev/173)

    function mb_scrub(?string $string, ?string $encoding = null): string { $encoding ??= mb_internal_encoding(); return mb_convert_encoding((string) $string, $encoding, $encoding); }

[cxj]

I think probably composer.json needs to be updated to use a version of Psalm that is newer than version 4.5.2, where the Psalm project fixed some bugs which prevented it from working with PHP 7.1 and 7.2. I have not tested this idea.

https://github.com/vimeo/psalm/releases/tag/4.5.2

[kevinsmith]

Hey @peter279k, thanks for the contribution! Sorry it took so long to respond. I had to make some other small updates to get the CI builds to start passing again on the 2.x branch first.

The void return types technically aren't required until PHPUnit 8, but it doesn't hurt anything to add them now and get it ready for future compatibility. I'll merge it in.

[peter279k]

Hi @kevinsmith, thanks for your reply. I glad you come back to concern this PR.

Thanks for merging this :).