Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PSR-15 RequestHandlerInterface for queue items #48

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Support for PSR-15 RequestHandlerInterface for queue items #48

merged 5 commits into from
Nov 13, 2019

Conversation

wirebox-platform
Copy link
Contributor

Problem/details/solution noted here:
#47

@wirebox-platform
Copy link
Contributor Author

re "All checks have failed" - looks like an issue with the CI & PHP version, rather than my PR itself?

@cxj
Copy link
Contributor

cxj commented Aug 22, 2019

The .travis.yml file needs to be updated to provide a workable test environment. You can append commits to your PR to fix this yourself, if so inclined.

I'm not sure why the PHP 7.2 requirement was reverted back in March. 7.1 active support ended last December and security patches for 7.1 end in December of this year. So really, any actively supported PHP project should be targeting only PHP versions 7.2 and 7.3 at this time. Maybe @kevinsmith can comment and clarify his thinking on this.

@wirebox-platform
Copy link
Contributor Author

Yeah, can't work it out. Seems like Travis installs the right version of PHPUnit but then uses a different one...

  - Installing phpunit/phpunit (7.5.15): Downloading (100%)


$ phpunit --coverage-clover=coverage.clover
PHPUnit 8.0.4 by Sebastian Bergmann and contributors.

@wirebox-platform
Copy link
Contributor Author

Done it. Seems there's a global phpunit bin on there @ version 8, so changed the script to use the vendor/bin/phpunit one explicitly. Now works & passes the checks :)

@cxj
Copy link
Contributor

cxj commented Aug 23, 2019

Looks good.

@kevinsmith
Copy link
Contributor

Everything looks good to me, it just needs a test. @wirebox-platform, if you just want to copy over the test I wrote for #49, that should do it:

public function testRequestHandlerInQueue()
{
$queue = [
new FakeMiddleware(),
new FakeMiddleware(),
new FakeMiddleware(),
$this->responder,
];
$requestHandler = new Relay($queue);
$this->assertRelay(new Relay([$requestHandler]));
}

@wirebox-platform
Copy link
Contributor Author

@kevinsmith all done :)

@kevinsmith kevinsmith merged commit 1735422 into relayphp:2.x Nov 13, 2019
@kevinsmith
Copy link
Contributor

Thank you, @wirebox-platform!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants