-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PSR-15 RequestHandlerInterface for queue items #48
Conversation
Problem/details/solution noted here: #47
re "All checks have failed" - looks like an issue with the CI & PHP version, rather than my PR itself? |
The I'm not sure why the PHP 7.2 requirement was reverted back in March. 7.1 active support ended last December and security patches for 7.1 end in December of this year. So really, any actively supported PHP project should be targeting only PHP versions 7.2 and 7.3 at this time. Maybe @kevinsmith can comment and clarify his thinking on this. |
Yeah, can't work it out. Seems like Travis installs the right version of PHPUnit but then uses a different one...
|
Done it. Seems there's a global phpunit bin on there @ version 8, so changed the script to use the vendor/bin/phpunit one explicitly. Now works & passes the checks :) |
Looks good. |
Everything looks good to me, it just needs a test. @wirebox-platform, if you just want to copy over the test I wrote for #49, that should do it: Relay.Relay/tests/RelayTest.php Lines 88 to 100 in 3041932
|
@kevinsmith all done :) |
Thank you, @wirebox-platform! |
Problem/details/solution noted here:
#47