Related to previous commit, this fixes "relative curves" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NITIAL point as their relative origin, in contravention of the spec: "For the relative versions of the commands, all coordinate values shall be relative to the current point at the start of the command." Added a simple SVG that demonstrates the bug, and shows it is fixed (test-wave-1.svg - should look like a roughly sinusoidal wave going horizontally across the screen)
|
(by "line" above I mean ... the text line of input from the source file) |
|
Ah, forgot to add: this includes an optional #define'd debug for all CGPath rendering, helps a lot with fixing these parser issues. It's defaulted to off, so compiled-out, but I recommend leaving it there as an option for future debugging. (SVGKit is now rendering all the inkscape files I throw at it, but it's still failing on some famous SVG files, e.g. the Tiger, so clearly tehre's still some debugging to do here) |
added 2 commits
November 24, 2011 12:24
…every SVG element
…e SVG document can be fetched by "id" tag (which is used in e.g. Inkscape as a general-purpose "name")
|
Awesome, thanks! I thought at first we could avoid using the flag and simply test the parameter to see if it's equal to zero, but then I realized that wouldnt work if one of the points in the path actually was 0,0 midstream. |
reklis
pushed a commit
that referenced
this pull request
Nov 24, 2011
Related to previous commit, this fixes "relative curves"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec: "For the relative versions of the commands, all coordinate values shall be relative to the current point at the start of the command."
...main repository is instead using the point "at the start of the line" (each new step is defined in the spec as a new "command")
Added a simple SVG that demonstrates the bug, and shows it is fixed (test-wave-1.svg - should look like a roughly sinusoidal wave going horizontally across the screen)