Fix that affects MANY inkscape files: implicit "absolute" line segments were being converted to "relative"

[adamgit]

I may have mis-read the spec, but my understanding is that in e.g.:

M 1,1 2,2, 3,3 z

...you should end up at (3,3)

Your code ends up at (6,6), because it assumes that the implicit "M"s were all relative.

This commit adds an extra BOOL to keep track of whethter the "initiating" command was relative or absolute.

There's also a very simple SVG file that demonstrates the bug clearly, and shows the fix working.

[adamgit]

...but: if I've got the spec wrong, then Inkscape and OS X Preview have it wrong too :). Both of them render as per the fixed code, not the pre-fixed code

[reklis]

Good catch, thanks :)

SLF

On Nov 23, 2011, at 11:50 AM, [email protected] wrote:

I may have mis-read the spec, but my understanding is that in e.g.:

M 1,1 2,2, 3,3 z

...you should end up at (3,3)

Your code ends up at (6,6), because it assumes that the implicit "M"s were all relative.

This commit adds an extra BOOL to keep track of whethter the "initiating" command was relative or absolute.

There's also a very simple SVG file that demonstrates the bug clearly, and shows the fix working.

You can merge this Pull Request by running:

git pull https://github.com/adamgit/SVGKit master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

• Fixed bug: relative line segments were being converted to absolute segments whenever the letter was not repeated in the command. You have to keep track of whether the initial command was relative or absolute - previous code was just "assuming" relative for all cases.
• Test-case that shows the previous fix working, as opposed to broken. Open in Inkscape - you should see a square rotated 45 degrees (ie a diamond shape) with the bottom-left segment a concave curve instead of a straigtht line. Before the fix, you just got an ugly mess.

-- File Changes --

M Core/SVGPathElement.m (58)
A Samples/test-diamond-with-one-curve.svg (62)

-- Patch Links --

https://github.com/reklis/SVGKit/pull/2.patch
https://github.com/reklis/SVGKit/pull/2.diff

---

Reply to this email directly or view it on GitHub:
#2