Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Fix for pip 10 #9

Closed
wants to merge 32 commits into from
Closed

Fix for pip 10 #9

wants to merge 32 commits into from

Conversation

RadicalZephyr
Copy link
Contributor

Fixes #8

@reillysiemens
Implement layabout and write tests
4b23aeb
@reillysiemens
Add badges
e8abf82
@reillysiemens
Make type annotations more specific
a2d7b71
@reillysiemens
Clean up documentation
eac6181
@reillysiemens
Remove name parameter from Layabout constructor
a0874d7
@reillysiemens
Make connect method private
a0bc987
@reillysiemens
Make slack attribute private
dc94f05
@reillysiemens
This ain't no Slack API token
10d0886
@reillysiemens
Break up handler registration tests
5a14a42
@reillysiemens
Reduce code repetition with mock_slack function
8355371
@reillysiemens
Simplify connection and read explanations
7d78d29
@reillysiemens
Break up event handling tests
ade5976
@reillysiemens
Short circuit initial connection logic
b898687
@reillysiemens
Improve reconnect logging
85704ee
@reillysiemens
Explicitly avoid providing a Slack token for env var test
c1edcf0
@reillysiemens
Require keyword arguments for all optional parameters
bbd5201
@reillysiemens
Improve handler validation
d20a3f5
@reillysiemens
Determine not to handle KeyboardInterrupt
0f2e1b4
@reillysiemens
Run splat handlers last
a374d83
@reillysiemens
Improve event loop exit debug logging
ac1a9fa
@reillysiemens
Retries start at 1
1d7cdc7
@reillysiemens
Default to truncated exponential backoff strategy
1ad128d
@reillysiemens
Refactor connection logic
e76f63b
@reillysiemens
Always install the latest testing and dev reqs
0bc671a
@reillysiemens
Fix missing return in connect_with_retry
361808c
@reillysiemens
Create EnvVar type, refactor connector dispatch
fdb7dcc
@reillysiemens
Use the empty string if no event type exists
fb02a06
@reillysiemens
Fix _create_slack type signature
d6facb1
@reillysiemens
Mark internal slack wrapper as Optional
b123739
@reillysiemens
Kick and scream if we don't get a SlackClient
6530bb4
@reillysiemens
Copy link
Owner

I appreciate the effort, @RadicalZephyr, but after reaching a decision on #7 I think this can most easily be resolved by not reading these files at all, removing the dependency on pip's internals, and just embedding the dependencies directly in the setup.py file, which should fix this issue.

I'll close this PR, but leave #8 open until setup.py has been fixed with the approach I just mentioned.

@reillysiemens reillysiemens mentioned this pull request Jun 17, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RadicalZephyr @reillysiemens