Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility for Rails 7.1.2 #202

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Fix compatibility for Rails 7.1.2 #202

merged 7 commits into from
Nov 16, 2023

Conversation

dalibor
Copy link
Contributor

@dalibor dalibor commented Nov 13, 2023 •
edited
Loading

Issue # (if available)

#200

Description of changes

  • Enable log subscriber silenced? patch only for 7.1.1
  • Fix ruby 3.2.2 and Rails 6.1 compatibility in test suite
  • Add test matrix for 7.1.1 for ActiveSupport::LogSubscriber#silenced? patch
  • Consistent matrix versions naming in ci workflow
  • Remove print from test
  • Add test/dummy/db/test.sqlite3* to gitignore

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@segiddins segiddins mentioned this pull request Nov 13, 2023
Merged
7 tasks
joshRpowell
joshRpowell reviewed Nov 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
Comment on lines 36 to 39
- rails: "7.1"
ruby: 3.1
ruby: "3.2"
- rails: "7.1"
ruby: 3.2
ruby: "3.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.1 /3.2 repeated 2x here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@darokel darokel mentioned this pull request Nov 15, 2023
Merged
@reidmorrison
Copy link
Owner

Thank you for the very thorough pull request. 🎉

@reidmorrison reidmorrison merged commit d35d467 into reidmorrison:master Nov 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnasevic-godaddy dnasevic-godaddy dnasevic-godaddy left review comments

@joshRpowell joshRpowell joshRpowell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dalibor @reidmorrison @joshRpowell @dnasevic-godaddy