Update Github Workflows

reidmorrison · Jul 4, 2024 · cca0312 · cca0312
1 parent d5d976f
commit cca0312
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -31,6 +31,8 @@ jobs:
 
           - rails: "7.1"
             ruby: "3.1"
+          - rails: "7.1b"
+            ruby: "3.1"
           - rails: "7.1.1"
             ruby: "3.2"
           - rails: "7.1"

diff --git a/rails_semantic_logger.gemspec b/rails_semantic_logger.gemspec
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 2.5"
   s.add_dependency "rack"
   s.add_dependency "railties", ">= 5.1"
-  s.add_dependency "semantic_logger", "~> 4.13"
+  s.add_dependency "semantic_logger", "~> 4.16"
   s.metadata = {
     "bug_tracker_uri"       => "https://github.com/reidmorrison/rails_semantic_logger/issues",
     "documentation_uri"     => "https://logger.rocketjob.io",

diff --git a/test/sidekiq_test.rb b/test/sidekiq_test.rb
@@ -91,7 +91,8 @@ class SidekiqTest < Minitest::Test
             name:       "BadJob",
             message:    "Start #perform",
             metric:     "sidekiq.queue.latency",
-            named_tags: {jid: nil, queue: "default"}
+            named_tags: {jid: nil, queue: "default"},
+            exception:        :nil
           )
           assert messages[0].metric_amount.is_a?(Float)
 
@@ -101,8 +102,8 @@ class SidekiqTest < Minitest::Test
             name:       "BadJob",
             message:    "Completed #perform",
             metric:     "sidekiq.job.perform",
-            named_tags: {jid: nil, queue: "default"}
-            # exception: { name: "ArgumentError", message: "This is a bad job" }
+            named_tags: {jid: nil, queue: "default"},
+            exception:  ArgumentError
           )
           assert messages[1].duration.is_a?(Float)
 
@@ -111,8 +112,8 @@ class SidekiqTest < Minitest::Test
             level:            :warn,
             name:             "BadJob",
             message:          "Job raised exception",
-            payload_includes: {context: "Job raised exception"}
-            # exception: { name: "ArgumentError", message: "This is a bad job" }
+            payload_includes: {context: "Job raised exception"},
+            exception:        :nil
           )
           assert_equal messages[2].payload[:job]["class"], "BadJob"
           assert_equal messages[2].payload[:job]["args"], []