Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Clade class public #72

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Dec 13, 2024

This is a small change related to the work on reichlab/variant-nowcast-hub#212

Having Clade as a public class means we can use it for type checking. For example, the target data scripts we're writing for the variant-nowcast-hub will benefit from typing the object returned by CladeTime.assign_clades().

Having Clade as a public class means we can use it
for type checking. For example, the target data
scripts we're writing for the variant-nowcast-hub
will benefit from typing the object returned by
CladeTime.assign_clades().
@bsweger bsweger force-pushed the bsweger/make-cladetime-public/variant-nowcast-hub-212 branch from 7a5f35c to 6388c0c Compare December 13, 2024 19:05
Copy link
Member

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cromulent.

I'm assuming that the underscore prefix meant internal?

@bsweger
Copy link
Collaborator Author

bsweger commented Dec 13, 2024

I'm assuming that the underscore prefix meant internal?

Heh, the underscore is the Python convention for making something private. But it's not enforced, it's just a polite way of saying "don't import me"

@bsweger bsweger merged commit ec8a764 into main Dec 13, 2024
2 checks passed
@bsweger bsweger deleted the bsweger/make-cladetime-public/variant-nowcast-hub-212 branch December 13, 2024 19:17
@zkamvar
Copy link
Member

zkamvar commented Dec 13, 2024

I'm assuming that the underscore prefix meant internal?

Heh, the underscore is the Python convention for making something private. But it's not enforced, it's just a polite way of saying "don't import me"

Oh! R has a similar convention, except it's a . prefix instead of an underscore (for compatibility with S, which used to use the underscore for assignment):

.x <- 1
x <- 2
ls()
#> [1] "x"

Created on 2024-12-13 with reprex v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants