-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added a new rehype plugin to plugins.md #185
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sohab Sk <[email protected]>
Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.
You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done! If you need it, here’s the original template<!--
Please check the needed checkboxes ([ ] -> [x]). Leave the
comments as they are, they won’t show on GitHub.
We are excited about pull requests, but please try to limit the scope, provide
a general description of the changes, and remember, it’s up to you to convince
us to land it.
-->
### Initial checklist
* [ ] I read the support docs <!-- https://github.com/rehypejs/.github/blob/main/support.md -->
* [ ] I read the contributing guide <!-- https://github.com/rehypejs/.github/blob/main/contributing.md -->
* [ ] I agree to follow the code of conduct <!-- https://github.com/rehypejs/.github/blob/main/code-of-conduct.md -->
* [ ] I searched issues and couldn’t find anything (or linked relevant results below) <!-- https://github.com/search?q=user%3Arehypejs&type=Issues -->
* [ ] If applicable, I’ve added docs and tests
### Description of changes
TODO
<!--do not edit: pr-->
Thanks, |
Thanks for sharing @ITZSHOAIB ! 🙇 General feedback on what gets included in the plugins list:
source: syntax-tree/hast#24 (comment) For your plugin I'm seeing:
Some additional pointers.
|
Thanks, @ChristianMurphy for a detailed reply.
And regarding test, I will add tests using suggested libraries. Thanks! |
A lot, and the same goes for including polyfills and down leveling to earlier versions of the JavaScript standard.
Version ranges are This does not mean lower default version, the package manager will still default to latest in the range. |
@ChristianMurphy Thanks for the time and effort. I have tried my best to update the package according to your suggestions. Please let me know if anything further required. |
@ChristianMurphy I have added some test cases as well. Thanks! |
Signed-off-by: Sohab Sk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 163 +9
=========================================
+ Hits 154 163 +9 ☔ View full report in Codecov by Sentry. |
Initial checklist
Description of changes
TODO