fix: don't crash if milestone progress is empty (#1238)

regro · Jan 21, 2025 · d0a4042 · d0a4042
1 parent 9ba36ae
commit d0a4042
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/regolith/templates/grantreport.txt b/src/regolith/templates/grantreport.txt
@@ -16,11 +16,11 @@ at least one of the 4 categories below)?
     Project: {{ prum.get('name') }}
     Objective: {{ prum.get('description') }}
     Activities:
-        {%- for milestone in prum.get('milestones') %}
+        {%- for milestone in prum.get('milestones', []) %}
         {%- if milestone.get("status") != "proposed" %}
       - {{ milestone.get("name") -}}:
-          Objective: {{ milestone.get("objective") }}
-          Outcomes: {{ milestone.get("progress").get("text") }}
+          Objective: {{ milestone.get("objective", "") }}
+          Outcomes: {{ milestone.get("progress", {}).get("text", "") }}
         {%- endif -%}
         {%- endfor -%}
 {%- endfor %}
@@ -31,11 +31,11 @@ at least one of the 4 categories below)?
     Project: {{ prum.get('name') -}}
     Objective: {{ prum.get('description') }}
     Activities:
-        {%- for milestone in prum.get('milestones') %}
-        {%- if milestone.get("status") != "proposed" %}
+        {%- for milestone in prum.get('milestones', []) %}
+        {%- if milestone.get("status", "") != "proposed" %}
       - {{ milestone.get("name") -}}:
-        Objective: {{ milestone.get("objective") }}
-        Outcomes; {{ milestone.get("progress").get("text") }}
+        Objective: {{ milestone.get("objective", "") }}
+        Outcomes; {{ milestone.get("progress", {}).get("text", "") }}
         {%- endif -%}
         {%- endfor -%}
 {%- endfor %}