-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some mypy issues #3203
base: main
Are you sure you want to change the base?
fix some mypy issues #3203
Conversation
Maybe backout the lockfile changes and try to relock here? |
/relock-conda |
It was just outdated, I can very easily now relock locally as well :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have lots of questions on this one. In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.
I cannot fix typing issues without removing wrongly typed dead code. I also need to change variable assignments minimally if the code is trying to change the type of a variable dynamically. If principles of inheritance are violated, adjustments need to be made to fix them. There are no "unassociated changes" in this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
=======================================
Coverage ? 77.84%
=======================================
Files ? 124
Lines ? 13417
Branches ? 0
=======================================
Hits ? 10445
Misses ? 2972
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fix
Description:
This PR fixes some mypy issues. Around 180 errors are left.
Checklist:
Cross-refs, links to issues, etc: