Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Fixes #2273

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Small Fixes #2273

merged 2 commits into from
Mar 18, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Mar 18, 2024

This fixes some minor issues that were discovered while working on #2239. There are also discussions about some of the things.

@ytausch ytausch marked this pull request as ready for review March 18, 2024 14:43
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.10%. Comparing base (bdc3ec2) to head (7f1ad3c).

Files Patch % Lines
conda_forge_tick/git_utils.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
- Coverage   71.11%   71.10%   -0.01%     
==========================================
  Files          97       97              
  Lines        9644     9642       -2     
==========================================
- Hits         6858     6856       -2     
  Misses       2786     2786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request and then we're good to go! Thank you!

@ytausch ytausch requested a review from beckermr March 18, 2024 15:53
@beckermr beckermr merged commit e3c3745 into regro:master Mar 18, 2024
4 of 5 checks passed
@ytausch ytausch deleted the small-fixes branch March 18, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants