-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include commit_message
body in pr_body
#1713
Conversation
Improve visibility of additional details from the `commit_message` by including in the migrator PR's body message.
FWIW usage like this case ( conda-forge/conda-forge-pinning-feedstock#4527 ) is one situation that might benefit from this added visibility. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
+ Coverage 68.14% 68.15% +0.01%
==========================================
Files 90 90
Lines 8494 8501 +7
==========================================
+ Hits 5788 5794 +6
- Misses 2706 2707 +1
☔ View full report in Codecov by Sentry. |
Thanks Matt! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry missed some newlines below. Fixed with PR ( #1714 )
Nice! This is what I expected to happen in the first place because GitHub does this when you open a PR for a branch with a single commit. Thanks, @jakirkham! |
Happy to help 🙂 Yeah it may be missed as we push 2 commits with these migrators or because the PR body is set In any event think your PR adding the commit message got at the core issue 🙏 The rest of this is just tinkering around the edges 😉 FWIW there's an example of what this looks like here: conda-forge/conda-forge-pinning-feedstock#4527 (comment) We can probably tweak it more. Though it does feel like we've got the basic pieces in place 🙂 |
Improve visibility of additional details from the
commit_message
by including in the migrator PR's body message.