-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW profiler decorator #1110
NEW profiler decorator #1110
Conversation
Can you implement this on the current jobs? |
Yes, it is possible. Give me some minutes and I will create the PR's |
I will implement this on the |
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 58.72% 58.76% +0.03%
==========================================
Files 52 57 +5
Lines 5018 5194 +176
==========================================
+ Hits 2947 3052 +105
- Misses 2071 2142 +71
Continue to review full report at Codecov.
|
There is a problem with using # process name -- aka profiler sub-folder
process_name = os.path.basename(__file__)
# check dir
os.makedirs(f"profiler/{process_name}", exist_ok=True) Then it should work like this, at |
Local test passed |
yes |
As commented by @CJ-Wright there is no need for two PR's with the same goal, then I will be closing #1111 as this PR now comprehends those changes too (in this case as a test for the new |
Once we test it with the |
Once tested and working well, we should go to #1085 |
Is this decorator being applied to the auto tick runs as well? |
not yet |
I want to confirm that it will work as expected, here it goes well but there is always an unexpected thing that can happen |
If it works, I will update the autotick with |
Do you need this PR merged first? |
Yes, if possible. The order should be something like:
I also can insert the update of |
f29e98e
to
d12200a
Compare
It would be good if all the changes related to the profiler decorator could be done in one PR. |
For that, I must figure out a way to remove the oldest files from |
I would leave that portion out for the moment, since formally it isn't about the decorator, also that requires manual changes to the database. |
yup, Y 'r right. So for the profiling that's all here. Unless there is other part of the bot I should add the decorator. |
You could put it on make graph, that might be interesting. |
This should enable us to inspect more functions with more freedom.