-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-396 two decimal digits for usd amount #2544
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie one thing to consider is if we want to round up the currency amount when in USD because when we cut the decimals o two we may end up charging less than the actual credits price - let me know what you think |
@erikalogie @S4mmyb any thoughts on this? |
I think we should round. |
I think we should round up to $10.90 in this case |
Ok so if it were $10.894, we would charge 10.89. |
Yep! <5 we round down, >=5 round up for that third decimal place. |
c1c129a
to
f1eb325
Compare
@blushi @erikalogie @S4mmyb have a look at this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One thing: If I type leading zeros in the currency input, then it's only transformed into a correct value, eg 0.1 when I type the final 1, while for the credits amount input, as long as I have one leading zero, I can't get others
I think both inputs should have consistent behaviors
3b4fad9
to
2191b4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving
Pending @erikalogie to have another look and translation to be fixed:
Let me know when this is fixed and I'll test again @r41ph |
@erikalogie please have look, the translation should be fixed now |
LGTM |
@r41ph could you run i18n:translate so it translates the missing es translations for "Must be at least"? |
Description
https://regennetwork.atlassian.net/browse/APP-396
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...